[DO NOT MERGE] break codegen test #52826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Travis is green!!! |
|
There's a |
|
But why does the CI runner not use the same LLVM version as Cc @rust-lang/infra |
|
We have different CI runners; one of them tests against the baseline LLVM (currently 5.0) whereas the rest test against the in-tree LLVM, which is ~7.0 at this point (well, master at some recent date) I believe. |
|
I see. Probably we were just unlucky then, with this bug slipping through until main bors time? Anyway, if there's no bug, I guess we can close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to see if I can reproduce the problem I noticed in #51361 where a codegen test was failing for pre-bors CI did not catch it.